Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app-testing): snapshot failure capture #15455

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix(app-testing): snapshot failure capture #15455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7adf4de
fix(app-testing): snapshot failure capture
pmoegenburg Jun 18, 2024
9a89962
Merge branch 'EXEC-436-lld-protocol-engine-command' into app-testing/…
pmoegenburg Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(app-testing): snapshot failure capture
  • Loading branch information
@pmoegenburg
pmoegenburg committed Jun 18, 2024
commit 7adf4de88bcba8927f447f7b7f12d0375f5c960f
20 changes: 8 additions & 12 deletions ...test_analysis_snapshot[041ad55e7b][OT2_S_v2_15_P300M_P20S_HS_TC_TM_dispense_changes].json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,41 +17,37 @@
"status": "succeeded"
},
{
"commandType": "custom",
"commandType": "comment",
"notes": [],
"params": {
"legacyCommandText": "Let there be light! True 🌠🌠🌠",
"legacyCommandType": "command.COMMENT"
"message": "Let there be light! True 🌠🌠🌠"
},
"result": {},
"status": "succeeded"
},
{
"commandType": "custom",
"commandType": "comment",
"notes": [],
"params": {
"legacyCommandText": "Is the door is closed? True 🚪🚪🚪",
"legacyCommandType": "command.COMMENT"
"message": "Is the door is closed? True 🚪🚪🚪"
},
"result": {},
"status": "succeeded"
},
{
"commandType": "custom",
"commandType": "comment",
"notes": [],
"params": {
"legacyCommandText": "Is this a simulation? True 🔮🔮🔮",
"legacyCommandType": "command.COMMENT"
"message": "Is this a simulation? True 🔮🔮🔮"
},
"result": {},
"status": "succeeded"
},
{
"commandType": "custom",
"commandType": "comment",
"notes": [],
"params": {
"legacyCommandText": "Running against API Version: 2.15",
"legacyCommandType": "command.COMMENT"
"message": "Running against API Version: 2.15"
},
"result": {},
"status": "succeeded"
Expand Down
2 changes: 1 addition & 1 deletion ...73][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum].json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"errorInfo": {
"args": "(\"Maximum is type 'str', but must be of parameter type 'int'\",)",
"class": "ParameterDefinitionError",
"traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"<string>\", line 1, in <module>\n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum.py\", line 104, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 94, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 266, in validate_options\n _validate_min_and_max(minimum, maximum, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 218, in _validate_min_and_max\n raise ParameterDefinitionError(\n"
"traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"<string>\", line 1, in <module>\n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum.py\", line 104, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 95, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 266, in validate_options\n _validate_min_and_max(minimum, maximum, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 218, in _validate_min_and_max\n raise ParameterDefinitionError(\n"
},
"errorType": "PythonException",
"isDefined": false,
Expand Down
20 changes: 8 additions & 12 deletions ...test/test_analysis_snapshot[0c4ae179bb][OT2_S_v2_15_P300M_P20S_HS_TC_TM_SmokeTestV3].json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,41 +17,37 @@
"status": "succeeded"
},
{
"commandType": "custom",
"commandType": "comment",
"notes": [],
"params": {
"legacyCommandText": "Let there be light! True 🌠🌠🌠",
"legacyCommandType": "command.COMMENT"
"message": "Let there be light! True 🌠🌠🌠"
},
"result": {},
"status": "succeeded"
},
{
"commandType": "custom",
"commandType": "comment",
"notes": [],
"params": {
"legacyCommandText": "Is the door is closed? True 🚪🚪🚪",
"legacyCommandType": "command.COMMENT"
"message": "Is the door is closed? True 🚪🚪🚪"
},
"result": {},
"status": "succeeded"
},
{
"commandType": "custom",
"commandType": "comment",
"notes": [],
"params": {
"legacyCommandText": "Is this a simulation? True 🔮🔮🔮",
"legacyCommandType": "command.COMMENT"
"message": "Is this a simulation? True 🔮🔮🔮"
},
"result": {},
"status": "succeeded"
},
{
"commandType": "custom",
"commandType": "comment",
"notes": [],
"params": {
"legacyCommandText": "Running against API Version: 2.15",
"legacyCommandType": "command.COMMENT"
"message": "Running against API Version: 2.15"
},
"result": {},
"status": "succeeded"
Expand Down
Loading