Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): update CommandText #15453

Merged
merged 2 commits into from
Jun 18, 2024
Merged

refactor(app): update CommandText #15453

merged 2 commits into from
Jun 18, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jun 18, 2024

Overview

CommandText should take a typography override. Let's use as with a default of p, since it's a consistent method for utilizing design-approved typography without generating our own one-off CSS styles. This adds the style override to the only place it's used, StepInfo.

Screenshot 2024-06-18 at 10 58 58 AM

Risk assessment

low

@mjhuff mjhuff requested review from sfoster1 and a team June 18, 2024 14:59
@mjhuff mjhuff requested a review from a team as a code owner June 18, 2024 14:59
@mjhuff mjhuff requested review from jerader and removed request for a team and jerader June 18, 2024 14:59
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, seems fine!

@mjhuff mjhuff merged commit e60953f into edge Jun 18, 2024
36 checks passed
@mjhuff mjhuff deleted the app_update-command-text branch June 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants