refactor(app): rename error recovery "hooks" dir to "utils" #15449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
requested review from
brenthagen
and removed request for
a team and
brenthagen
sfoster1
requested changes
Jun 18, 2024
There was a problem hiding this comment.
I dunno, I do think it's nice to have hooks in hooks/ and stuff that's not hooks in utils/. I appreciate that they might be used in different ways, and that the hooks do have standard names, but I think it's just nice and neat to keep them in separate directories also.
|
Per convo, we'll go with separate directories for now with the intention of breaking the hooks directory into data vs. component-utilizing-hooks later (all the ER hooks are data hooks, currently). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A lot of the Error Recovery hooks used as utils are dependent on non-ER-hooks used as utils, and instead of making some weird cross-dependency between hooks that act like utils in a hooks directory and utils that are only used by hooks in a utils directory, I think it makes sense to keep everything in a "utils" directory and call it a day.
I'm open to thoughts/comments/concerns. There are a good number of utils in "utils", but if it's any consolation, we are most likely done adding any utils for MVP at this point (well, maybe there will be a couple more for good measure, I don't know yet).
Test Plan
Risk assessment
none