Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add a running step counter to the ODD #15448

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jun 18, 2024

Closes EXEC-550

Overview

Adds a nifty step counter per design.

Screenshot 2024-06-17 at 7 27 48 PM

Test Plan

  • Run any protocol your heart desires. Verify there is a step counter.

Changelog

  • Added a protocol step counter to the ODD.

Risk assessment

low!

@mjhuff mjhuff requested a review from a team June 18, 2024 01:39
@mjhuff mjhuff requested a review from a team as a code owner June 18, 2024 01:39
@mjhuff mjhuff requested review from shlokamin and removed request for a team and shlokamin June 18, 2024 01:39
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nifty!

Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjhuff mjhuff merged commit 0333837 into edge Jun 18, 2024
20 checks passed
@mjhuff mjhuff deleted the app_add-step-counter-odd branch June 18, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants