Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): handle empty rtp file #15435

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jun 17, 2024

Overview

update protocol run slideouts to disable value confirmation if no file uploaded

Test Plan

Screenshot 2024-06-17 at 2 19 24 PM

setup from protocol

  • select a CSV RTP protocol and begin setup on desktop
  • select a robot and "proceed to parameters"
  • verify that when the CSV file parameter is empty (upload input renders), "confirm values" is disabled and hovering produces "Add the required CSV file to continue." tooltip

setup from device

  • select a robot and "run a protocol" from device overflow menu
  • select a CSV RTP protocol and "proceed to parameters"
  • verify that when the CSV file parameter is empty (upload input renders), "confirm values" is disabled and hovering produces "Add the required CSV file to continue." tooltip

Changelog

  • add tooltip to ChooseProtocolSlideout and ChooseRobotToRunProtocolSlideout footers' "Confirm values" button when disabled due to a missing CSV file parameter value
  • add translation keys
  • update tests

Review requests

auth js

Risk assessment

low

@ncdiehl11 ncdiehl11 requested review from koji and jerader June 17, 2024 18:19
@ncdiehl11 ncdiehl11 marked this pull request as ready for review June 17, 2024 19:11
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner June 17, 2024 19:11
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm! This is good to merge after the tests are fixed 💅

@ncdiehl11 ncdiehl11 merged commit fad34ea into edge Jun 17, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the feat_app-handle-empty-rtp-file branch June 17, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants