Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(app): add FileCard tests and update error copy #15423

Merged
merged 4 commits into from
Jun 14, 2024
Merged

test(app): add FileCard tests and update error copy #15423

merged 4 commits into from
Jun 14, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jun 14, 2024 •
edited by jira bot
Loading

closes AUTH-517

Overview

add FileCard tests and update error copy

Changelog

  • add test file for new FileCard component
  • update copy for incorrect file type error message on slideout

Risk assessment

low

@ncdiehl11 ncdiehl11 requested review from koji and jerader June 14, 2024 15:21
@ncdiehl11 ncdiehl11 marked this pull request as ready for review June 14, 2024 15:21
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner June 14, 2024 15:21
@ncdiehl11 ncdiehl11 requested a review from koji June 14, 2024 15:27
koji
koji approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test looks good to me!
thank you for adding the test.

app/src/organisms/ChooseRobotSlideout/FileCard.tsx Show resolved Hide resolved
@ncdiehl11 ncdiehl11 merged commit ac2cdbe into edge Jun 14, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the chore_app-filecard-tests branch June 14, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader Awaiting requested review from jerader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncdiehl11 @koji