fix types and lint

api-client/src/runs/types.ts

@@ -130,9 +130,16 @@ export interface LabwareOffsetCreateData {
  vector: VectorOffset
 }
 
-export interface RunTimeParameterCreateData {
- [key: string]: string | boolean | number
+interface FileRunTimeParameterCreateData {
+ [key: string]: string | number | boolean
 }
+interface ValueRunTimeParameterCreateData {
+ [key: string]: { id: string }
+}
+
+export type RunTimeParameterCreateData =
+ | FileRunTimeParameterCreateData
+ | ValueRunTimeParameterCreateData
 
 export interface CommandData {
  data: RunTimeCommand

app/src/organisms/Devices/utils.ts

@@ -97,7 +97,7 @@ export function getRunTimeParameterValuesForRun(
 ): RunTimeParameterCreateData {
  return runTimeParameters.reduce((acc, param) => {
  if (param.type === 'csv_file') {
- return { ...acc, [param.variableName]: param.file?.id }
+ return { ...acc, [param.variableName]: { id: param.file?.id } }
  } else {
  return param.value !== param.default
  ? { ...acc, [param.variableName]: param.value }

app/src/organisms/ProtocolSetupParameters/ChooseEnum.tsx

@@ -11,11 +11,11 @@ import {
 import { RadioButton } from '../../atoms/buttons'
 import { useToaster } from '../ToasterOven'
 import { ChildNavigation } from '../ChildNavigation'
-import type { RunTimeParameter } from '@opentrons/shared-data'
+import type { ChoiceParameter } from '@opentrons/shared-data'
 
 interface ChooseEnumProps {
  handleGoBack: () => void
- parameter: RunTimeParameter
+ parameter: ChoiceParameter
  setParameter: (value: boolean | string | number, variableName: string) => void
  rawValue: number | string | boolean
 }
@@ -33,9 +33,6 @@ export function ChooseEnum({
  const handleOnClick = (newValue: string | number | boolean): void => {
  setParameter(newValue, parameter.variableName)
  }
- if (!('default' in parameter)) {
- return null
- }
  const resetValueDisabled = parameter.default === rawValue
 
  return (

components/src/molecules/ParametersTable/index.tsx

@@ -7,14 +7,14 @@ import {
 } from '@opentrons/shared-data'
 import { BORDERS, COLORS } from '../../helix-design-system'
 import { SPACING, TYPOGRAPHY } from '../../ui-style-constants/index'
+import { Chip } from '../../atoms/Chip'
 import { StyledText } from '../../atoms/StyledText'
 import { Tooltip, useHoverTooltip } from '../../tooltips'
 import { Icon } from '../../icons'
 import { Flex } from '../../primitives'
 import { DISPLAY_INLINE, FLEX_MAX_CONTENT } from '../../styles'
 
 import type { RunTimeParameter } from '@opentrons/shared-data'
-import { Chip } from '../../atoms'
 
 interface ProtocolParameterItemsProps {
  runTimeParameters: RunTimeParameter[]