fix(protocol-designer): reset the touchTip checkbox when labware changes #15407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
koji,
SyntaxColoring and
ncdiehl11
and removed request for
a team
you mean the protocol Matthew attached to the ticket? |
@koji oops yes my bad! I just attached it here too. |
koji
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RESC-273
Overview
This is an interested bug. Basically, a user selected a labware where touch tip is allowed and checked the touch tip box. Then the user changed the labware to one where touch tip is not allowed. The touch tip check box was disabled but not actually de-selected. This resulted in an unwanted erroneous
touchTipcommand to be generated in step-generation.The fix is not super straightforward though. What I changed here is when the aspirate, dispense, or mix labware changes, the touch tip checkbox field is reset. This fix is fine however if a protocol is already experiencing this error, it will not be automatically fixed upon importing their protocol.
The more involved fix (simply code-wise but has big implications) would be ensuring that a touch tip command is only generated if the touch tip checkbox is selected AND there is a height is selected. But that would mean changing the current behavior of PD which I do not think is a good idea.
Test Plan
Upload the attached file to protocol designer in production. Navigate to the 15th step in the timeline (which is a transfer step) and open the advanced settings. change the dispense labware to
Amplicon PCRsee that the touch tip field is selected.Now, upload the same file to protocol designer on this branch, navigate to the timeline, open the 15th step again. Open up the advanced settings and change the dispense labware to
Amplicon PCR. See that the touch tip field is NOT selected. (this is because the setting has been properly reset).16S Metagenomik Amplicon PCR Clean-Up (manuelle beads zugabe) Optimiert_10-06-2024.json
Changelog
moveLiquidandmixforms touch tip checkbox fields if labware changesReview requests
see test plan
Risk assessment
low