feat(app, app-shell-odd): add function to read csv file from usb for rtp phase2 #15403
Conversation
add read csv files from usb close AUTH-
add reading csv files from usb drive to odd close AUTH-
| // ToDo (kk:06/12/2024) get files from the endpoint: GET /protocols/{protocolId}/dataFiles/ | ||
| // return format: https://opentrons.atlassian.net/browse/AUTH-428 |
There was a problem hiding this comment.
don't we already have api client and react api client utils for this? may as well use them!
| return { | ||
| type: 'shell: ROBOT_MASS_STORAGE_DEVICE_ENUMERATED', | ||
| payload: { | ||
| rootPath: '', |
There was a problem hiding this comment.
rootPath being empty string seems suspicious... @sfoster1 im not fully understanding how it should be used. also does this belong in the redux/shell/update module?
|
| @@ -47,6 +56,18 @@ const enumerateMassStorage = (path: string): Promise<string[]> => | |||
| ) | |||
| .catch(() => []) | |||
| .then(flatten) | |||
| .then(contents => { | |||
| if (filterCSV) { | |||
| const regex = /._\w/gm | |||
There was a problem hiding this comment.
can you add a comment for what this regex is searching for?
| export function registerFilePath( | ||
| dispatch: Dispatch | ||
| ): (action: Action) => unknown { |
There was a problem hiding this comment.
i thought we were gonna reuse watchForMassStorage since it's already doing a file system watch. doesnt this sort of duplicate all of the computation?
There was a problem hiding this comment.
maybe we can call this registerDataFiles or registerCsvFiles because this reducer will be searching specifically for protocol data files
| setCsvFileInfo, | ||
| }: ChooseCsvFileProps): JSX.Element { | ||
| const { t } = useTranslation('protocol_setup') | ||
| const csvFilesOnUSB = useSelector(getFilePaths).payload.filePaths ?? [] |
There was a problem hiding this comment.
is getFilePaths an action creator or a selector? if its meant to be a selector, we need to rework it to take in state and return file paths (rather than an action)
| export const getFilePaths = (state: State): SendFilePathsAction => ({ | ||
| type: SEND_FILE_PATHS, | ||
| payload: { filePaths: state.shell.filePaths }, |
There was a problem hiding this comment.
is this meant to be a selector or an action?
| void enumerateMassStorage(action.payload.rootPath, true).then( | ||
| csvFilePaths => { | ||
| dispatch(sendFilePaths(csvFilePaths)) | ||
| } | ||
| ) |
There was a problem hiding this comment.
in the system update reducer, we respond to shell:ROBOT_MASS_STORAGE_DEVICE_ENUMERATED and filter out all of the provided file paths with ONLY relevant update files (system zips).
in the usb case, can we do something similar? we could respond to shell:ROBOT_MASS_STORAGE_DEVICE_ENUMERATED (like we already are), but have a special function (similar to getLatestMassStorageUpdateFiles that only grabs CSV files for us. that way we can draw a distinction between getting ALL files in the usb dir vs specific files relevant to a particular redux module (system update, or csv files)
There was a problem hiding this comment.
something like getLatestMassStorageCsvFiles or getLatestMassStorageUpdateFiles.
and that function's job is just to filter for relevant CSV files
There was a problem hiding this comment.
trying the above method, but action.payload.filePaths is empty - [] without calling enumerateMassStorage.
There was a problem hiding this comment.
robotMassStorageDeviceEnumerated gets called by enumerateMassStorage, which means that as long as you respond to an action of type ROBOT_MASS_STORAGE_DEVICE_ENUMERATED by calling this new getLatestMassStorageCsvFiles function you should be good.
is the action of type ROBOT_MASS_STORAGE_DEVICE_ENUMERATED getting dispatched?
There was a problem hiding this comment.
yes
rootPath has the path but filePaths don't have any path.
unplug the flash drive from Flex -> plug into the flash drive on Flex
Jun 28 21:12:10 Flex1234567890 opentrons-robot-app.sh[5458]: Mass storage device /media/sda1 removed but this was not an update source
Jun 28 21:12:16 Flex1234567890 opentrons-robot-app.sh[5458]: New mass storage device sda1 detected
Jun 28 21:12:17 Flex1234567890 opentrons-robot-app.sh[5458]: shell:ROBOT_MASS_STORAGE_DEVICE_ENUMERATED []
Jun 28 21:12:17 Flex1234567890 opentrons-robot-app.sh[5458]: no updates found in mass storage device
|
this will be taken over by #15551 |
Overview
add a function that loads csv files from an usb-drive, update protocol card & pinned protocol, and add ChooseCsvFile component (display csv files on USB).
close AUTH-460, AUTH-468, and partially AUTH-462 and AUTH-470
This PR doesn't update protocol details screen and Parametes screen. They will be implemented in a following pr since this PR's main part is displaying csv files on USB.
The following yellow background shows up when turning on the feature flag and a protocol name includes
RTP.The rendering condition part will be update in a following pr.
Confirm selectionpart will be implemented and a function to control radio buttons (AUTH-458)Test Plan
Changelog
Review requests
Risk assessment