Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol-designer): append definitionId to the labwareId in migration #15396

Merged
merged 4 commits into from
Jun 12, 2024
Merged

fix(protocol-designer): append definitionId to the labwareId in migration #15396

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e13e7b
fix(protocol-designer): append definitionId to the labwareId in migra…
jerader Jun 12, 2024
82555fc
remove console
jerader Jun 12, 2024
7fd3df0
fix cypress
jerader Jun 12, 2024
57bcc57
address comment
jerader Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address comment
  • Loading branch information
@jerader
jerader committed Jun 12, 2024
commit 57bcc576f38603fcba02a3aa91418341f6bf12bb
2 changes: 1 addition & 1 deletion protocol-designer/src/load-file/migration/7_0_0.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ export const migrateFile = (
if (!getIsAdapter(labwareId)) {
const definitionId = labware[labwareId].definitionId
const labId =
labwareId === 'fixedTrash' || labwareId.includes(definitionId)
labwareId.includes(definitionId) || labwareId === 'fixedTrash'
? labwareId
: `${labwareId}:${definitionId}`
acc[labId] = labwareLocationUpdate[labwareId]
Expand Down
Loading