refactor(protocol-designer): check if adapter through allowedRoles #15386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokamin
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-506
Overview
This is not really a bug (yet) but will be a bug once #15385 merges in. Basically, we updated the categorizations of some labware by changing the
displayCategory. This is fine, we just can't rely on thedisplayCategoryfor cataloging the adapters in PD, instead we need to rely on theallowedRoles. This PR fixes that.Test Plan
Not much to test here, just check that my logic makes sense!
Changelog
deckSetupcomponent to base the adapter info off ofincludedRolesinstead ofdisplayCategoryReview requests
see test plan
Risk assessment
low