Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(labware-library): direct Protocol Library links to new library #15315

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix(labware-library): direct Protocol Library links to new library #15315

merged 2 commits into from
Jun 3, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jun 3, 2024 •
edited
Loading

closes AUTH-79

Overview

direct main navigation and 'Protocols' menu Protocol Library links to new protocol library (https://library.opentrons.com/)

Test Plan

  • build Labware Library off this branch
  • click the Protocol Library links in main navigation and under 'Protocols' menu
  • confirm that you are directed to new Protocol Library at https://library.opentrons.com/
Screenshot 2024-06-03 at 12 09 53 PM

Changelog

  • update Protocol Library link URLs

Review requests

js

Risk assessment

low

@ncdiehl11 ncdiehl11 requested review from koji, shlokamin, jerader and a team June 3, 2024 16:12
@ncdiehl11 ncdiehl11 self-assigned this Jun 3, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review June 3, 2024 16:28
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner June 3, 2024 16:28
jerader
jerader approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ncdiehl11 ncdiehl11 merged commit 4529146 into edge Jun 3, 2024
14 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_ll-update-library-links branch June 3, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@koji koji Awaiting requested review from koji

@shlokamin shlokamin Awaiting requested review from shlokamin

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @jerader