Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api, performance-metrics): clean up performance-metrics tracking #15289

Merged
merged 22 commits into from
Jun 5, 2024
Merged

chore(api, performance-metrics): clean up performance-metrics tracking #15289

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
53fe590
feat: Add storing analysis context on track
DerekMaggio Apr 23, 2024
7e63eda
a case study on why you should not let your PR get 280 commits behind
DerekMaggio May 30, 2024
6e5411b
fix: call track as a function and not a decorator
DerekMaggio May 30, 2024
2e010fe
fix: underlying function exception was not being raised
DerekMaggio May 30, 2024
d1254fe
chore: remove a comment
DerekMaggio May 30, 2024
b094468
chore: way clearer typing, docs, and logic
DerekMaggio May 30, 2024
40da8f6
mypy is fighting back
DerekMaggio May 30, 2024
f08e2d5
fix: track should be a decorator
DerekMaggio May 31, 2024
52ed95f
fix tests
DerekMaggio May 31, 2024
92c793f
update track_analysis
DerekMaggio May 31, 2024
cc0dc74
remove unnecessary test
DerekMaggio May 31, 2024
b73010f
chore: not tracking client-side analysis
DerekMaggio Jun 3, 2024
70017cd
tests: no unit tests because they have to be hacked to be written
DerekMaggio Jun 3, 2024
f11ba35
chore: add TODO
DerekMaggio Jun 3, 2024
4035e33
formatting
DerekMaggio Jun 3, 2024
06fec00
chore: revert project packaging stuff
DerekMaggio Jun 3, 2024
bf63522
test: remove unused test function
DerekMaggio Jun 3, 2024
3bea700
chore: move to other PR
DerekMaggio Jun 3, 2024
4dea812
fix comment
DerekMaggio Jun 3, 2024
bff1b53
chore: Add TODO to remind me to look into something
DerekMaggio Jun 3, 2024
1af9d2a
ugh, formatting
DerekMaggio Jun 3, 2024
23cfdae
fix: everything except execution outside the wrapper
DerekMaggio Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add TODO
  • Loading branch information
@DerekMaggio
DerekMaggio committed Jun 3, 2024
commit f11ba35617d5badcede1f4594cd5fd5bf0e349f9
1 change: 1 addition & 0 deletions api/src/opentrons/util/performance_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def _get_robot_context_tracker() -> SupportsTracking:
def track_analysis(func: UnderlyingFunction) -> UnderlyingFunction:
"""Track the analysis of a protocol and optionally store each run."""

# TODO: derek maggio (06-03-2024): generalize creating wrapper functions for tracking different states
@functools.wraps(func)
def wrapper(
*args: UnderlyingFunctionParameters.args,
Expand Down
Loading