fix(app): address Design QA comments for modules in deck config #15150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Deck hardware table padding in desktop protocol setup. Fix padding in no modules detected modal. standardize copy for title and description fo protocol setup steps. standardize copy for header and description in ODD location conflict modal Closes RQA-2687, Closes RQA-2686, Closes RQA-2684, Closes RQA-2685, Closes RQA-2692
b-cooper
requested review from
smb2268,
brenthagen and
CaseyBatten
and removed request for
jerader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix Deck hardware table padding in desktop protocol setup. Fix padding in no modules detected modal.
standardize copy for title and description fo protocol setup steps. standardize copy for header and
description in ODD location conflict modal
Closes RQA-2687, Closes RQA-2686, Closes RQA-2684, Closes RQA-2685, Closes RQA-2692
Screenshots
RQA-2687
RQA-2686
RQA-2684
RQA-2685
RQA-2692
Risk assessment
low