Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): fix UpdateAppModal style #15149

Merged
merged 3 commits into from
May 9, 2024
Merged

fix(app): fix UpdateAppModal style #15149

merged 3 commits into from
May 9, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented May 9, 2024 •
edited
Loading

Closes RQA-2675

Overview

fix padding, border, and buttons on UpdateAppModal according to designs

Screenshot 2024-05-09 at 4 37 17 PM

Test Plan

  • trigger update app modal
  • verify style fixes

Changelog

  • convert footer buttons to PrimaryButton and SecondaryButton components
  • add border to top of footer
  • add padding to footer

Review requests

js

Risk assessment

low

@ncdiehl11 ncdiehl11 force-pushed the fix_app-update-app-modal-style branch from 88ebe6e to fa1b372 Compare May 9, 2024 19:18
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 9, 2024 19:21
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 9, 2024 19:21
@ncdiehl11 ncdiehl11 requested review from mjhuff and removed request for a team May 9, 2024 19:21
@ncdiehl11 ncdiehl11 self-assigned this May 9, 2024
jerader
jerader approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

mjhuff
mjhuff approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating

@ncdiehl11 ncdiehl11 requested a review from mjhuff May 9, 2024 20:35
mjhuff
mjhuff approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the the new hrs 🚀

@ncdiehl11 ncdiehl11 merged commit db21c14 into chore_release-7.3.0 May 9, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-update-app-modal-style branch May 9, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff approved these changes

@jerader jerader jerader approved these changes

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ncdiehl11 @mjhuff @jerader