Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): remove excess padding in TestShakeSlideout #15142

Merged
merged 1 commit into from
May 9, 2024
Merged

fix(app): remove excess padding in TestShakeSlideout #15142

merged 1 commit into from
May 9, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented May 9, 2024 •
edited
Loading

closes RQA-2516

Overview

remove excess padding in TestShakeSlideout

Screenshot 2024-05-09 at 10 25 50 AM

Test Plan

  • connect to robot with heater shaker module
  • open heater shaker module card overflow > test shake slideout
  • verify padding of latch/shake speed content

Changelog

  • fix padding

Review requests

js

Risk assessment

low

@ncdiehl11 ncdiehl11 self-assigned this May 9, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 9, 2024 14:36
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 9, 2024 14:36
@ncdiehl11 ncdiehl11 requested review from shlokamin, koji and jerader and removed request for a team May 9, 2024 14:36
koji
koji approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Before merging this into the target, please post a screenshot to the ticket and get Mel's approval.

@ncdiehl11 ncdiehl11 merged commit 7c410bf into chore_release-7.3.0 May 9, 2024
26 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-testshakeslideout-style branch May 9, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@shlokamin shlokamin Awaiting requested review from shlokamin shlokamin is a code owner automatically assigned from Opentrons/js

@jerader jerader Awaiting requested review from jerader

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncdiehl11 @koji