refactor(protocol-designer): tiprack option redesign to not have scroll #15141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
TamarZanzouri,
koji and
ncdiehl11
and removed request for
a team and
TamarZanzouri
jerader
commented
May 9, 2024
| @@ -118,7 +118,10 @@ function DropdownIndicator( | |||
| [styles.flipped]: props.selectProps.menuIsOpen, | |||
| })} | |||
| > | |||
| <Icon name="menu-down" className={cx(styles.dropdown_indicator_icon)} /> | |||
| <Icon | |||
| name="menu-down-pd" | |||
There was a problem hiding this comment.
i have a feeling this change might affect a few app components - maybe we can come back to find a better fix for this in both the App and PD after 7.3 is out since 7.3 is contained to a release branch
|
the scrollbars are shown up on the sandbox and the look is different from your screenshot.
|
@koji thanks for posting the screenshot! I thought there were no scrollbars 😢 maybe i need to just hide any scrollbars that could appear |
koji
reviewed
May 9, 2024
protocol-designer/src/components/modals/FilePipettesModal/TiprackOption.tsx
Outdated
Show resolved
Hide resolved
koji
approved these changes
May 9, 2024
jerader
force-pushed
the
pd_fix-tiprack-option
branch
from
06d0c33
to
96b4bcd
Compare
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-2681
Overview
Pipette selection modal now has a better UI for the tiprack selection where the text doesn't require a left/right scroll
Test Plan
Create a flex or ot-2 protocol and open the edit pipettes section and observe the UI of the tipracks
Changelog
Review requests
see test plan
Risk assessment
low