fix(api): Automatic tip tracking index out of range fix #15135
Merged
+128
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses RQA-2700
Automatic tip tracking when iterating through multiple tip racks did not take into account progression range across those tipracks resulting in the potential for an index out of range error to manifest under certain conditions. These changes seek to fix that.
Test Plan
Ensure that API 2.18 protocols consume tipracks without encountering an index out of range error manifesting as an out of tips error when iterating through multiple tipracks using tip-cluster based automatic tip tracking. Protocols such as the one below should execute without issue.
Changelog
Review requests
Do these changes appear comprehensive enough given existing safegaurds within the tiprack iteration logic?
Risk assessment
Low, fixes oversight.