Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): misc bugs with copy, ui, and liquid color error #15116

Merged
merged 3 commits into from
May 7, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented May 7, 2024

closes AUTH-386 AUTH-387 AUTH-385 partially RQA-2682

Overview

This PR addresses a handful of random things found in candidate-A for PD 8.1:

  1. fixes ui for multiple tipracks to match the modules page
  2. update tuberack warning
  3. fix whitescreen when entering an invalid color hex code
  4. update an image to a transparent img

Test Plan

  • Create an ot-2 protocol and choose a pipette with more than 3 tiprack options. select all 3 tiprack options and see that the rest of the options are disabled and the checkbox disappears. Then on the module page, see that the thermocycler gen1 does not have a white background (i only partially addressed the module images since i'm waiting for design to provide the remaining module images with a transparent background).
  • Then go to liquids tab and try to add an invalid color of 000000, see that there is an error message saying its an invalid color.
  • Finally, go to the deck map tab and add a tuberack. Add a transfer step and specify the aspirate and dispense to occur in the tuberack. See that the warning banner text says that the default aspirate and dispense height is 1mm.

Changelog

  • update copy and an image
  • fix bug with rendering the error text for liquid colors
  • expand equipmentOption to include the pipette tip type and adjust the tooltip text and disabled state

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner May 7, 2024 16:40
@jerader jerader requested review from koji and ncdiehl11 and removed request for a team May 7, 2024 16:40
@@ -117,7 +117,7 @@ export function LiquidEditForm(props: LiquidEditFormProps): JSX.Element {
serialize: values.serialize || false,
})
}

console.log('errors', errors)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to keep for debugging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops forgot to delete it, thank you!

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. The sandbox worked as expected.
Once the images are replaced, this pr is good to go.

@jerader
Copy link
Collaborator Author

jerader commented May 7, 2024

The changes look good to me. The sandbox worked as expected. Once the images are replaced, this pr is good to go.

@koji thanks! i think i'll fix the images in a follow up since i'm still waiting for design to give me the new images with the transparent background. In that followup i'll also update all the images to the optimized versions you made.

@koji
Copy link
Contributor

koji commented May 7, 2024

The changes look good to me. The sandbox worked as expected. Once the images are replaced, this pr is good to go.

@koji thanks! i think i'll fix the images in a follow up since i'm still waiting for design to give me the new images with the transparent background. In that followup i'll also update all the images to the optimized versions you made.

that totally makes sense

@jerader jerader merged commit d9aa18f into edge May 7, 2024
14 checks passed
@jerader jerader deleted the pd_random-fixes branch May 7, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants