Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): fix choose number input field behavior #15099

Merged
merged 1 commit into from
May 7, 2024
Merged

fix(app): fix choose number input field behavior #15099

merged 1 commit into from
May 7, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented May 6, 2024

Overview

fix choose number input field behavior

choose_num.mov

close RQA-2651

Test Plan

Changelog

Review requests

Risk assessment

@koji koji requested review from ncdiehl11 and jerader May 6, 2024 17:45
@koji koji added the authorship label May 6, 2024
@koji koji marked this pull request as ready for review May 6, 2024 21:25
@koji koji requested a review from a team as a code owner May 6, 2024 21:25
@koji koji removed the request for review from a team May 6, 2024 21:25
ncdiehl11
ncdiehl11 approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looks good, including an error toast if I try to go back with an empty value. nice

@koji koji merged commit f6bd225 into chore_release-7.3.0 May 7, 2024
30 checks passed
@koji koji deleted the fix_RQA-2651 branch May 7, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdiehl11 ncdiehl11 ncdiehl11 approved these changes

@jerader jerader Awaiting requested review from jerader

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koji @ncdiehl11