fix(app): Fix dropdown menu open direction issue #15091
Conversation
add a function to detect the open direction for dropdown menu close RQA-
koji
changed the title
| window.removeEventListener('resize', handlePositionCalculation) | ||
| window.removeEventListener('scroll', handlePositionCalculation) | ||
| } | ||
| }, [filterOptions.length]) |
There was a problem hiding this comment.
Looks good but I think we may want to change the dependency array to include the available height? In testing, I zoomed such that the menu should pop up on top and it looks good. But then, if you zoom out such that there is room for the menu to pop up on bottom, it still pops up on top.
There was a problem hiding this comment.
added window.innerHeight since availableHeight is a local var but windw.innerHeight change has an impact on the calc.
There was a problem hiding this comment.
I think the intuition about grabbing the grandparent element is correct, but the grandparent implementation in the use of the dropdown menu is not the whole slideout
Maybe we can have an optional container reference to pass into DropdownMenu and default to that if it is not undefined?
There was a problem hiding this comment.
What do you think about this?
setDropdownPosition(
dropdownBottom > availableHeight &&
window.innerHeight < availableHeight
? 'top'
: 'bottom'
)There was a problem hiding this comment.
I think this is almost perfect except we are not accounting for the footer
There was a problem hiding this comment.
@ncdiehl11
updated. thank you for your help!
Overview
add open direction to dropdown menu
close RQA-2662
Test Plan
run RTP protocol and try to open dropdown menus
Changelog
Review requests
Risk assessment
low