Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): format <ul> in release notes #15081

Merged
merged 2 commits into from
May 3, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented May 2, 2024

Closes RQA-2674

Overview

We recently migrated our .md renderer and tweaked some of the HTML tags. <ul>s didn't have the appropriate font and color applied, so let's add that. I've confirmed with @ecormany and Sue that this is what we want!

Current Behavior

image-20240502-144058

Fixed Behavior

Screenshot 2024-05-02 at 4 48 31 PM

Test Plan

  • Build a local version of the app make -C app-shell dist-osx or equivalent.
  • Run the local version, usually in the app-shell/dist/ directory.
  • Open the update modal for a robot and verify the release notes <ul>s are styled appropriately.

Risk assessment

low

@mjhuff mjhuff requested review from ecormany and a team May 2, 2024 21:00
@mjhuff mjhuff requested a review from a team as a code owner May 2, 2024 21:00
@mjhuff mjhuff requested review from brenthagen and koji and removed request for a team and brenthagen May 2, 2024 21:00
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bless

@mjhuff mjhuff merged commit 8fef724 into chore_release-7.3.0 May 3, 2024
20 checks passed
@mjhuff mjhuff deleted the app_format-ul-release-notes branch May 3, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants