feat(app): add labware selection and volume entry screens #15074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smb2268
commented
May 2, 2024
| @@ -10,6 +10,7 @@ | |||
| .simple-keyboard.oddTheme1.hg-theme-default { | |||
| width: 100%; | |||
| height: 100%; | |||
| border-radius: 0; | |||
There was a problem hiding this comment.
Designs for this component show no rounded edges, the default for the keyboard component we use is border-radius 5
smb2268
commented
May 2, 2024
| @@ -8,7 +8,7 @@ export interface QuickTransferSetupState { | |||
| tipRack?: LabwareDefinition2 | |||
| source?: LabwareDefinition2 | |||
| sourceWells?: string[] | |||
| destination?: LabwareDefinition2 | |||
| destination?: LabwareDefinition2 | 'source' | |||
There was a problem hiding this comment.
We allow users to select either a new labware or use the same labware as they selected for the source
b-cooper
reviewed
May 3, 2024
b-cooper
approved these changes
May 3, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix PLAT-176, PLAT-177, PLAT-237
Overview
This PR adds all functionality necessary for the Source Labware Selection, Destination Labware Selection, and Volume screens of the quick transfer flow
Test Plan
With FF turned on, navigate to the protocols tab and launch the quick transfer flow. All steps of the initial wizard now exist, so you can navigate through the whole flow. After volume entry, since summary screen is not yet implemented the flow will close and final state of information gathered from the flow will be printed in the console.
Video not uploading but I posted it here: https://opentrons.slack.com/archives/C06LPQN1YHM/p1714685498743729
Changelog
constants.tsfile for this repo so that we don't have to do the well geometry comparison at run timeReview requests
Look through the logic of the utils - I tried to explain functionality in comments in the test cases but let me know if you have questions or if anything doesn't look right!
Risk assessment
Low, behind FF