Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix tooltip behavior for disabled Restore default value on RTP slideout #15071

Merged

Conversation

ncdiehl11
Copy link
Collaborator

Overview

When all parameter values in the RTP slideout match their respective defaults, the link to restore all default values should be disabled. Designs specify that clicking this button will render a tooltip explaining its disabled reason for 2 seconds, but hovering over it will not.

Test Plan

  • begin setup on Desktop App for RTP protocol from protocol details
  • select any robot and continue to parameters
  • observe that "Restore default values" link is disabled because all RTP values match defaults
  • click restore values link
  • observe that a tooltip renders with the info "No custom values specified"
  • repeat all of the above starting from device details rather than from protocol details

Changelog

  • modify tooltip behavior to show on click and disappear after 2 seconds, only if link is disabled
  • add tests

Review requests

auth js

Risk assessment

low

@ncdiehl11 ncdiehl11 self-assigned this May 2, 2024
@ncdiehl11 ncdiehl11 requested review from koji and jerader May 2, 2024 15:54
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 2, 2024 17:00
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 2, 2024 17:00
@koji koji added the authorship label May 3, 2024
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both cases worked as expected
the changes look good to me.

the target might be 7.3.0 branch?

@ncdiehl11 ncdiehl11 changed the base branch from edge to chore_release-7.3.0 May 3, 2024 18:39
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 3, 2024 18:39
@ncdiehl11 ncdiehl11 force-pushed the fix_app-restore-values-disabled-tooltip branch from 04ef2b0 to 4f4bdd6 Compare May 3, 2024 18:49
@ncdiehl11 ncdiehl11 force-pushed the fix_app-restore-values-disabled-tooltip branch from 76643e7 to c5f8ac0 Compare May 3, 2024 20:22
@ncdiehl11 ncdiehl11 merged commit dfd0f31 into chore_release-7.3.0 May 3, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-restore-values-disabled-tooltip branch May 3, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants