Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): stop-requested hanging on stop when awaiting-recovery #15066

Conversation

TamarZanzouri
Copy link
Contributor

Overview

closes https://opentrons.atlassian.net/browse/EXEC-403.
fix bug related to stop-requested hanging when issuing a StopAction when in AwaitingRecovery state.

Test Plan

  • use ff for recoverable commands
  • upload a protocol that will fail on a recoverable command.
  • issue a stop action while in awaiting-recovery
  • run should stop.

Review requests

is test sufficient ?

Risk assessment

low. bug fix.

@TamarZanzouri TamarZanzouri requested a review from a team as a code owner May 1, 2024 18:13
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahm that'd be it, nice find!

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants