Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-client): sanitize file name thoroughly #15062

Merged
merged 1 commit into from
May 1, 2024

Conversation

brenthagen
Copy link
Contributor

Overview

more thoroughly remove all spaces and special characters from splash file name

closes RQA-2668

Test Plan

unit tested util

Changelog

  • Sanitizes splash file name thoroughly

Review requests

check splash

Risk assessment

low

more thoroughly remove all spaces and special characters from splash file name

closes RQA-2668
@brenthagen brenthagen requested a review from a team May 1, 2024 16:55
@brenthagen brenthagen requested a review from a team as a code owner May 1, 2024 16:55
@brenthagen brenthagen requested review from smb2268 and removed request for a team and smb2268 May 1, 2024 16:55
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good 🗜️

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me
I tested on the robot and the custom logo is shown correctly.

@brenthagen brenthagen merged commit 044be7a into edge May 1, 2024
14 checks passed
@brenthagen brenthagen deleted the api-client_sanitize-file-name branch May 1, 2024 19:28
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
more thoroughly remove all spaces and special characters from splash file name

closes RQA-2668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants