Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): anonymize pipette wizard flows #15055

Merged
merged 2 commits into from
May 1, 2024

Conversation

brenthagen
Copy link
Contributor

Overview

anonymizes pipette name in ODD pipette wizard flows and firmware update result modal

closes PLAT-297

Screen Shot 2024-04-30 at 8 17 57 PM Screen Shot 2024-04-30 at 8 19 03 PM

Test Plan

manually verified wizard screens

Changelog

  • Anonymizes pipette wizard flows

Review requests

check as many pipette wizard flows as practical

Risk assessment

low

anonymizes pipette name in ODD pipette wizard flows and firmware update result modal

closes PLAT-297
@brenthagen brenthagen requested a review from a team May 1, 2024 00:46
@brenthagen brenthagen requested a review from a team as a code owner May 1, 2024 00:46
@brenthagen brenthagen requested review from jerader and removed request for a team and jerader May 1, 2024 00:46
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on the robot, the changes look good on my end.
Pipette attach/detach and firmware update flows have been anonymized.

@brenthagen brenthagen merged commit 1cea210 into edge May 1, 2024
17 of 20 checks passed
@brenthagen brenthagen deleted the app_anon-pipette-wizard-flows branch May 1, 2024 19:30
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
anonymizes pipette name in ODD pipette wizard flows and firmware update
result modal

closes PLAT-297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants