Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): disable module calibration if heating or cooling #15054

Merged

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 30, 2024

closes RQA-2630

Overview

If a temperature module, thermocycler, or heater shaker is not idle (heating, cooling, holding at target, or error), we should disable calibration.

Disabled reason precedence:

  1. pipette calibration required before module calibration
  2. module too hot to calibrate
  3. module in process of heating/cooling

Test Plan

  • start heating/cooling a temperature module/heater shaker module/thermocycler block or lid from module card overflow menu
  • click module overflow menu again
  • observe that (re)calibrate option is disabled and tooltip gives appropriate information
Screenshot 2024-05-01 at 11 10 06 AM

Changelog

  • in module overflow menu component, check module status for heating or cooling
  • add heating/cooling condition to disabled boolean for (re)calibrate
  • display tooltip according to disabled reason
  • add test coverage

Review requests

js

Risk assessment

low

If a temperature module, thermocycler, or heater shaker is heating or cooling, we should disable
calibration.
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 1, 2024 13:51
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 1, 2024 13:51
@ncdiehl11 ncdiehl11 requested review from brenthagen and removed request for a team May 1, 2024 13:51
@ncdiehl11 ncdiehl11 force-pushed the fix_app-disable-module-cal-if-heating branch from 1ad14aa to ce42875 Compare May 1, 2024 14:12
@ncdiehl11 ncdiehl11 self-assigned this May 1, 2024
@ncdiehl11 ncdiehl11 requested review from a team, koji and jerader May 1, 2024 15:11
@koji koji added the authorship label May 3, 2024
@koji
Copy link
Contributor

koji commented May 3, 2024

@ncdiehl11
Is this going to edge?

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this branch with a flex and the app worked as expected.
The changes look good to me!

@ncdiehl11
Copy link
Collaborator Author

ncdiehl11 commented May 3, 2024

@ncdiehl11 Is this going to edge?

@koji Maybe it should target release branch?

@ncdiehl11 ncdiehl11 changed the base branch from edge to chore_release-7.3.0 May 3, 2024 18:56
@ncdiehl11 ncdiehl11 merged commit 0526f55 into chore_release-7.3.0 May 3, 2024
24 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-disable-module-cal-if-heating branch May 3, 2024 18:58
@koji
Copy link
Contributor

koji commented May 3, 2024

@ncdiehl11 Is this going to edge?

@koji Maybe it should target release branch?

@ncdiehl11 I think this should go to 7.3.0 since the ticket mentions to 7.3.0 as fix version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants