Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): activate input-field focus-visble #15048

Merged
merged 2 commits into from
Apr 30, 2024
Merged

fix(app): activate input-field focus-visble #15048

merged 2 commits into from
Apr 30, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 30, 2024

Overview

add tabIndex to activate input-field focus-visble

input_field-focus_visible.mov

close RQA-2671

Test Plan

Changelog

Review requests

Risk assessment

low

add tabIndex to activate input-field focus-visble

close RQA-2671
@koji koji requested review from ncdiehl11 and jerader April 30, 2024 16:43
@koji koji marked this pull request as ready for review April 30, 2024 16:43
@koji koji requested a review from a team as a code owner April 30, 2024 16:43
@koji
Copy link
Contributor Author

koji commented Apr 30, 2024

@ncdiehl11
I noticed that there is ternary in focus-visible. Do we need that?

    &:focus-visible {
      border: 1px ${BORDERS.styleSolid}
        ${hasError ? COLORS.red50 : COLORS.grey60};
      outline: 2px ${BORDERS.styleSolid} ${COLORS.blue50};
      outline-offset: 3px;
    }

Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koji koji merged commit 8084b9a into edge Apr 30, 2024
20 checks passed
@koji koji deleted the fix_RQA-2671 branch April 30, 2024 22:10
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* fix(app): activate input-field focus-visble
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants