Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix remove Parameters header if a protocl is non-RTP #15036

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 29, 2024

Overview

fix remove Parameters header if a protocl is non-RTP

[before]

empty state parameters with header

[after]

Screenshot 2024-04-29 at 1 30 12 PM

focus-visible

dropdown_focus-visible.mov

close RQA-2656 RQA-2659

Test Plan

Changelog

Review requests

Risk assessment

fix remove Parameters header if a protocl is non-RTP

close RQA-2656
@koji koji requested review from ncdiehl11 and jerader April 29, 2024 17:34
@koji koji marked this pull request as ready for review April 29, 2024 17:34
@koji koji requested a review from a team as a code owner April 29, 2024 17:34
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I appreciate the additional explanatory comments for DropdownMenu!

@koji koji merged commit ccce785 into edge May 1, 2024
24 checks passed
@koji koji deleted the fix_RQA-2656 branch May 1, 2024 14:33
@koji
Copy link
Contributor Author

koji commented May 1, 2024

@mjhuff thank you for reviewing my prs!

Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* fix(app): fix remove Parameters header if a protocl is non-RTP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants