refactor(app): style desktop "Applied Labware Offset Data" buttons #15034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
requested review from
brenthagen
and removed request for
a team and
brenthagen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-2637
Overview
Somewhere in the border radius/component refactoring work, the desktop LPC offset buttons lost their margins. This adds them back, accounting for only the places we have these tabs (instead of altering the
RoundTabcomponent.I think we could discuss snapshot testing to prevent these kinds of style bugs from happening in the future. Chatted with Shlok about this - it's ticketed here.
Current Behavior
Fixed Behavior
Risk assessment
low