fix(api): disallow hashing we using a fixit command #15026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanni-t
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
LGTM!
Discussed with @TamarZanzouri- As @sfoster1 said in the other PR, we should look into making command intent be always required because the nullability can keep causing confusion. But it is quite an important change that might affect HTTP API (& probably JSON protocols) and would need dedicated testing so we should avoid making such a change this late into the QA process.
So the approach in this PR looks good and we will add a ticket to make the intent be required for post-release.
api/tests/opentrons/protocol_engine/commands/test_hash_command_params.py
Outdated
Show resolved
Hide resolved
…_params.py Co-authored-by: Sanniti Pimpley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
follow up for #14908.
disallow hashing for fixit commands.
Test Plan
POST a fixit command and make sure the hash is
None.Risk assessment
low. set hash to
Nonewhen using a fixit command