feat(app): validate factory mode slideout input #15025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add validation and errors to input on factory mode slideout initial step closes PLAT-281
vegano1
reviewed
Apr 26, 2024
| @@ -58,6 +61,10 @@ export function FactoryModeSlideout({ | |||
| ) | |||
| const isOEMMode = oemModeSetting?.value ?? null | |||
|
|
|||
| const robot = useRobot(robotName) | |||
| const sn = robot?.status != null ? getRobotSerialNumber(robot) : null | |||
| const last = sn?.substring(sn.length - 4) | |||
There was a problem hiding this comment.
Can this throw if const sn is null?
There was a problem hiding this comment.
don't think it's necessary - last will be undefined in that case and never pass validation. i think the better move is to disable the initial "Setup mode" button if sn is null to prevent opening the slideout
vegano1
reviewed
Apr 26, 2024
| ): Record<string, FieldError> => { | ||
| const factoryModeInput = data.factoryModeInput | ||
| let errorMessage: string | undefined | ||
| if (factoryModeInput.length > 0 && factoryModeInput !== last) { |
There was a problem hiding this comment.
should we handle empty input factoryModeInput.length == 0 here? or is this handled elsewhere?
There was a problem hiding this comment.
ha, yes we should. good catch
vegano1
reviewed
Apr 26, 2024
| @@ -153,7 +192,11 @@ export function FactoryModeSlideout({ | |||
| footer={ | |||
| <> | |||
| {currentStep === 1 ? ( | |||
| <PrimaryButton onClick={handleSubmitFactoryPassword} width="100%"> | |||
| <PrimaryButton | |||
| disabled={errors.factoryModeInput != null} | |||
There was a problem hiding this comment.
ok, so this handles empty input, cool
vegano1
approved these changes
Apr 26, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
add validation and errors to input on factory mode slideout initial step closes PLAT-281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add validation and errors to input on factory mode slideout initial step
closes PLAT-281
Test Plan
manually verified error states and validation
Changelog
Review requests
check the input field for correct validation and errors
Risk assessment
low