chore(app-shell): no hard links when building the app locally #15024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the symlink errors that occur when building the app via "make -C app-shell dist-XYZ".
mjhuff
changed the title
shlokamin
approved these changes
Apr 26, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Fixes the symlink errors that occur when building the app locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the symlink errors that occur when building the app via "make -C app-shell dist-XYZ". Looks like newer versions of electron-builder change the symlinking, and locally trying to build the app will fail with symlink issues (at least for some OS's). This is the workaround.
We already do this when we run CI, so this just makes this not an issue locally.
Test Plan
make -C app-shell dist-XYZ. Verify that the command does not fail with a symlinking error (I've tested on all dist-XYZ variations, but feel free to double-check me).Risk assessment
low