fix(app): fix restore default values button behavior #15017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently restore default values button is tappable when tapping confirm values button close RQA-2639
jerader
reviewed
May 1, 2024
| @@ -151,6 +151,7 @@ export function ProtocolSetupParameters({ | |||
| secondaryButtonProps={{ | |||
| buttonType: 'tertiaryLowLight', | |||
| buttonText: t('restore_defaults'), | |||
| disabled: isLoading || startSetup, | |||
There was a problem hiding this comment.
random nit but line 138 could be a console.error and have a more descriptive log, such as "should not hit here, this is a bad param"
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* fix(app): fix restore default values button behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
currently restore default values button is tappable when tapping confirm values button.
This PR makes restore default values button is disabled during confirming values.
close RQA-2639
Test Plan
set up a RTP protocol, change a runtime parameter and tap confirm values.
then try to tap restore default values button and check that the restore default values modal doesn't show up.
Changelog
Review requests
Risk assessment
low