fix(app): fix ordering of gripper exit so success screen doesn't flash #15012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-2629
Overview
Robot finished homing a few seconds before the modal closed, so the robot is moving spinner was unmounted before the modal closed, flashing success screen again. This PR refactors that behavior to match what was done for pipettes in #14580
Test Plan
Run through a gripper flow and see that the modal closes from the loader screen
Screen.Recording.2024-04-25.at.2.06.08.PM.mov
Changelog
Mimic behavior of pipette wizard flows for
isExitinglogic andhandleCleanUpAndCloseReview requests
Look over changes
Risk assessment
Low