Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): check /instruments for 96 channel attachment #15011

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Apr 25, 2024

Fix RQA-2633

Overview

I disabled the /pipettes query for Flex in favor of using /instruments but missed switching the reference for whether a 96 channel is attached to this data.

Test Plan

Look at the desktop app with a 96 channel attached, no Right Pipette card should be visible

Changelog

Check left pipette data from /instruments to see if it is a 96 channel

Review requests

Look over changes

Risk assessment

Low

@smb2268 smb2268 self-assigned this Apr 25, 2024
@smb2268 smb2268 requested a review from a team as a code owner April 25, 2024 18:05
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good to me.
I don't see any empty pipette card anymore!

@smb2268 smb2268 merged commit 4ea08cb into edge Apr 25, 2024
20 checks passed
@smb2268 smb2268 deleted the app_96-right-mount branch April 25, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants