chore(mono): Enforce notification hooks in the app #15010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-419
Overview
Enforces the usage of the notification wrapper for the equivalent HTTP hook if the wrapper exists. We need this, so we don't accidentally poll in the app/ODD when we can use notifications instead.
I went with the lint approach over the "global mock and fail test" approach for a couple reasons:
Also, I've intentionally excluded test files from the lint rule for a few reasons:
react-api-client
in a test file, and the lint rule will catch these spots even when the rule doesn't apply.Test Plan
useNotify
equivalent, such asuseCurrentMaintenanceRun
. Verify that lint fails.Risk assessment
low