fix(app): disable the factory mode complete and restart robot button when robot is busy #15006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when robot is busy passes a robotIsBusy boolean to the factory mode slideout to disable the complete and restart robot button when the robot is busy. this covers the edge case where the robot becomes busy after the slideout is opened. closes RQA-2632
brenthagen
requested review from
mjhuff
and removed request for
a team and
mjhuff
vegano1
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
passes a robotIsBusy boolean to the factory mode slideout to disable the complete and restart robot button when the robot is busy. this covers the edge case where the robot becomes busy after the slideout is opened.
closes RQA-2632
Test Plan
manually verified disabled complete and restart robot button when the robot is busy, e.g. a current run exists
Changelog
Review requests
check the edge case, start a run/maintenance run after the factory mode slideout is open
Risk assessment
low