fix(app): add robot serial number to BuildrootAnalyticsData #15000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add robot serial number to BuildrootAnalyticsData close RQA-2386
koji
commented
Apr 24, 2024
| @@ -32,16 +32,20 @@ export function getBuildrootAnalyticsData( | |||
| ? getRobotUpdateRobot(state) | |||
| : getViewableRobots(state).find(r => r.name === robotName) ?? null | |||
|
|
|||
| if (updateVersion === null || robot === null) return null | |||
There was a problem hiding this comment.
updateVersion === null is causing the following issue.
The app sends events that are related to robotUpdate but most cases cannot send data(currentVersion, currentSystem, updateVersion).
There was a problem hiding this comment.
Yeah, the way you're handling this seems better!
mjhuff
approved these changes
Apr 25, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* fix(app): add robot serial number to BuildrootAnalyticsData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add robot serial number to
BuildrootAnalyticsDataand modify the condition to send existing data.If robot is not null, sending
currentSystem,currnetVersion, androbotSerialNumberwould be good even ifupdateVersionis null since those properties are reflected the current user's robot situation.close RQA-2386
Test Plan
project_token can be found in Project Settings page
Changelog
Review requests
Risk assessment