refactor(protocol-designer): tweak when module cards are disabled in … #14995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…createFileWizard closes AUTH-369
jerader
requested review from
koji and
ncdiehl11
and removed request for
a team
koji
reviewed
Apr 24, 2024
| const hasMagneticBlock = Object.values(modules || {}).some( | ||
| module => module.type === MAGNETIC_BLOCK_TYPE | ||
| ) | ||
| let filteredModuleLength = moduleLength |
There was a problem hiding this comment.
nit
moduleLength is not used by anything except filteredModuleLength
let filteredModuleLength = modules != null ? Object.keys(modules).length : 0
koji
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…createFileWizard
closes AUTH-369
Overview
There were 2 things that the
getIsSlotAvailablelogic did not account for and it isThis pr fixes that and adds test coverage
Test Plan
I have good unit testing for this so main priority is reviewing the logic
If you want, turn on the MoaM feature flag and create a flex protocol On the "Additional Items" page, add 6 temperature modules and see that the TC is disabled since there is only 1 slot available. Add another module and see that all modules + waste chute slot cards are disabled except for the magnetic block (this is because it is placed in an inner deck slot)
Changelog
Review requests
see test plan
Risk assessment
low