Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(robot-server): add deck_configuration notification publisher #14986

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Apr 23, 2024

Closes EXEC-168

Overview

Add a deck configuration publisher to the robot server. This will enable the app to avoid polling for updated deck config state. An app-sided PR will follow this one.

Test Plan

  • On the desktop app/ODD, mess around with the deck config. Any time you update the deck state, you should see an MQTT refetch flag published on the robot-server/deck_configuration topic. Postman is the easiest way to visualize this.

Changelog

  • Add a deck configuration publisher to the robot server.

Review requests

  • Double check me on the store.py changes. I don't think there's anything weird/wrong here, but it would be nice for a python dev to confirm. We just publish a refetch flag any time the store is updated, and I believe I've covered the only spots updates happen.

Risk assessment

low - this is about as vanilla as you can get for a notification publisher

@mjhuff mjhuff requested review from SyntaxColoring and a team April 23, 2024 16:58
@mjhuff mjhuff requested a review from a team as a code owner April 23, 2024 16:58
@mjhuff mjhuff changed the title feat(robot-server): add a deck_configuration notification publisher feat(robot-server): add deck_configuration notification publisher Apr 23, 2024
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not part of the initial notifications but changes make sense to me and match other notifications

@mjhuff mjhuff merged commit 33f37ea into edge Apr 25, 2024
7 checks passed
@mjhuff mjhuff deleted the robot-server_add-deck-configuration-publisher branch April 25, 2024 15:57
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
…4986)

Closes EXEC-168

Add a deck configuration publisher to the robot server. This will enable the app to avoid polling for updated deck config state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants