refactor(performance-metrics): separate storage logic from tracker #14982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7985dc7
to
9789604
Compare
sfoster1
approved these changes
Apr 26, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
…14982) # Overview Closes https://opentrons.atlassian.net/browse/EXEC-415 - Pulls out storage logic from tracker into MetricsStore object - Defines MetricsMetadata to store information about the MetricsStore object # Test Plan - Modified file storage test in performance-metrics to use the new classes. - Loads file content and validates it - Modified test_track_analysis test in api/test_cli - Loads file content and validates it # Changelog - Create MetricsMetadata in shared data which defines where to store data, what to call it, and the headers - Create MetricsStore which handles creating any necessary directories or files and then storing data to the files - Remove storage logic from RobotContextTracker then instantiate MetricsStore and call to its methods to handle data storage # Review requests None # Risk assessment Low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes https://opentrons.atlassian.net/browse/EXEC-415
Test Plan
Changelog
Review requests
None
Risk assessment
Low