feat(app): create hooks to anonymize instrument display names #14978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEM mode requires removing "Flex" from pipette and gripper names in the ODD. these hooks wrap the shared-data helpers used to get instrument display names and remove "Flex" when in OEM mode on the ODD closes PLAT-261
brenthagen
requested review from
jerader
and removed request for
a team and
jerader
vegano1
approved these changes
Apr 26, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
OEM mode requires removing "Flex" from pipette and gripper names in the ODD. these hooks wrap the shared-data helpers used to get instrument display names and remove "Flex" when in OEM mode on the ODD. closes PLAT-261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
OEM mode requires removing "Flex" from pipette and gripper names in the ODD. these hooks wrap the shared-data helpers used to get instrument display names and remove "Flex" when in OEM mode on the ODD
closes PLAT-261
TODO: pipette wizard flows
Test Plan
manually verified removal of "Flex" from instrument names. Will add unit tests in PLAT-295.
Changelog
Review requests
check the anonymization with OEM mode on - "Flex" should be removed in the ODD but still present in desktop app
Risk assessment
medium-ish, some reworking of logic in shared components