fix(app): configure modules during calibration, shorten heater shaker fixture name #14953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fixture name At the beginning of the module calibration flow, the user is asked to locate the module on the deck. This integrated the deck configurator component directly into this location selction step of the module calibration wizard. the selected location will now be saved directly to deck configuration. Closes RQA-2603
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14953 +/- ##
==========================================
+ Coverage 67.50% 76.11% +8.60%
==========================================
Files 2521 41 -2480
Lines 72090 2746 -69344
Branches 9311 0 -9311
==========================================
- Hits 48666 2090 -46576
+ Misses 21228 656 -20572
+ Partials 2196 0 -2196
Flags with carried forward coverage won't be shown. Click here to find out more. |
CaseyBatten
approved these changes
Apr 19, 2024
Comment on lines
65
to
+69
| const cutoutId = deckConfig.find( | ||
| cc => cc.opentronsModuleSerialNumber === attachedModule.serialNumber | ||
| cc => | ||
| cc.opentronsModuleSerialNumber === attachedModule.serialNumber && | ||
| (attachedModule.moduleType !== THERMOCYCLER_MODULE_TYPE || | ||
| cc.cutoutFixtureId === THERMOCYCLER_V2_FRONT_FIXTURE) |
There was a problem hiding this comment.
This fix looks appropriate and solves the issues we were having in the case of multiple thermocycler fixtures proccing on the front end from the deck config.
brenthagen
reviewed
Apr 19, 2024
Comment on lines
107
to
111
| // If module fixture is loaded, still visualize singleSlotFixture underneath for consistency | ||
| Object.entries(MODULE_FIXTURES_BY_MODEL).reduce<CutoutFixtureId[]>( | ||
| (acc, [_model, fixtures]) => [...acc, ...fixtures], | ||
| [] | ||
| )) |
There was a problem hiding this comment.
this renders single slot fixtures in (under) every cutout...maybe this is ok?
There was a problem hiding this comment.
interesting..., yeah maybe it should only be done for module fixtures. Good catch! I'll patch it up
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
… fixture name (#14953) # Overview At the beginning of the module calibration flow, the user is asked to locate the module on the deck. This integrated the deck configurator component directly into this location selction step of the module calibration wizard. the selected location will now be saved directly to deck configuration. Closes [RQA-2603](https://opentrons.atlassian.net/browse/RQA-2603) # Review requests - Run module calibration and confirm that the selected location reflects the deck configuration # Risk assessment low [RQA-2603]: https://opentrons.atlassian.net/browse/RQA-2603?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
At the beginning of the module calibration flow, the user is asked to locate the module on the deck.
This integrated the deck configurator component directly into this location selction step of the
module calibration wizard. the selected location will now be saved directly to deck configuration.
Closes RQA-2603
Review requests
Risk assessment
low