Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): ensure ApplyHistoricOffsets renders on non-RTP protocols #14948

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix(app): ensure ApplyHistoricOffsets renders on non-RTP protocols #14948

merged 2 commits into from
Apr 18, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 18, 2024 •
edited by jira bot
Loading

closes RQA-2606

Overview

The ApplyHistoricOffsets component was accidentally removed from the ChooseRobotToRunProtocolSlideout component for non-RTP protocols. Here, I add it back.

Test Plan

  • upload protocol without RTP
  • start protocol setup
  • verify that labware offsets checkbox shows on slideout footer
Screenshot 2024-04-18 at 12 59 34 PM

Changelog

  • add back ApplyHistoricOffsets component to slideout footer

Review requests

js

Risk assessment

low

@ncdiehl
fix(app): ensure ApplyLabwareOffsets renders on non-RTP protocols
b7904c1 
The ApplyLabwareOffsets component was accidentally removed from the ChooseRobotToRunProtocolSlideout
component for non-RTP protocols. Here, I add it back.
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 18, 2024 16:59
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 18, 2024 16:59
@ncdiehl11 ncdiehl11 requested review from mjhuff and removed request for a team April 18, 2024 16:59
jerader
jerader approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment not related about renaming a const but lgtm

mjhuff
mjhuff reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, haha. Could we get some testing to cover this? - grepping for the"No offset data available" and the Learn More button clicking/ rendering what it should would be nice!

@ncdiehl11 ncdiehl11 merged commit 6d91a56 into edge Apr 18, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-slideout-labware-offsets branch April 18, 2024 18:26
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@ncdiehl11 @Carlos-fernandez
fix(app): ensure ApplyHistoricOffsets renders on non-RTP protocols (#…
e180631 
…14948)

closes RQA-2606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff left review comments

@jerader jerader jerader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncdiehl11 @mjhuff @jerader @ncdiehl