fix(opentrons-ai-client): apply GlobalStyle to the application #14936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply GlobalStyle to the application close AUTH-351
koji
commented
Apr 17, 2024
| @@ -19,7 +19,6 @@ | |||
| }, | |||
| "homepage": "https://github.com/Opentrons/opentrons", | |||
| "dependencies": { | |||
| "@fontsource/dejavu-sans": "5.0.3", | |||
There was a problem hiding this comment.
We need this to display Greek characters, but OpenAI API cannot handle Greek characters well, so we don't need to use the font for this application.
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* fix(opentrons-ai-client): apply GlobalStyle to the application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
apply GlobalStyle to the application
I forgot to apply
GlobalStyleto the entire app.close AUTH-351
Test Plan
Changelog
mainReview requests
Risk assessment
low