fix(app): add optional description icon to dropdownMenu #14934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
TamarZanzouri,
koji and
ncdiehl11
and removed request for
a team and
TamarZanzouri
koji
reviewed
Apr 17, 2024
koji
approved these changes
Apr 17, 2024
i'll make a new ticket! @koji |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-311
Overview
Add a description icon with a description tooltip to choices dropdown menu for RTP.
Test Plan
Upload the protocol attached to the ticket's comment and see that there is an icon with a tooltip which matches the description text in the parameters slideout for desktop app
Changelog
DropdownMenuto include an optional tooltip text which renders an icon and tooltipReview requests
see test plan
Risk assessment
low