feat(protocol-designer): edit multiple modules modal + row #14933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
koji and
ncdiehl11
and removed request for
a team
jerader
commented
Apr 17, 2024
| const { control, handleSubmit } = useForm<EditMultipleModulesModalValues>() | ||
| const moduleLocations = Object.values(allModulesOnDeck) | ||
| .filter(module => module.type === moduleType) | ||
| .map(temp => `cutout${temp.slot}`) |
There was a problem hiding this comment.
the DeckConfigurator uses cutoutIds so i had to do a bunch of converting between cutoutId and slot 🤔. i guess i could make a map to easily map between slot and cutoutId so i don't have to do this. idk i think it is okay as is but could definitely be cleaner 😅
koji
reviewed
Apr 17, 2024
protocol-designer/src/components/modals/EditModulesModal/EditMultipleModulesModal.tsx
Show resolved
Hide resolved
koji
reviewed
Apr 17, 2024
protocol-designer/src/components/modals/EditModulesModal/EditMultipleModulesModal.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Apr 17, 2024
protocol-designer/src/components/modals/EditModulesModal/EditMultipleModulesModal.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Apr 17, 2024
koji
reviewed
Apr 17, 2024
koji
reviewed
Apr 17, 2024
koji
reviewed
Apr 17, 2024
koji
reviewed
Apr 17, 2024
koji
reviewed
Apr 17, 2024
koji
reviewed
Apr 17, 2024
koji
reviewed
Apr 17, 2024
protocol-designer/src/components/modules/__tests__/MultipleModuleRow.test.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Apr 18, 2024
protocol-designer/src/components/modals/EditModulesModal/EditMultipleModulesModal.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Apr 18, 2024
| cleanup() | ||
| }) | ||
| it('renders modal and buttons with no error', () => { | ||
| vi.mocked(getLabwareIsCompatible).mockReturnValue(true) |
There was a problem hiding this comment.
nit
using vitest-when would be better.
maybe leaving ToDo is good for the future.
koji
reviewed
Apr 18, 2024
...-designer/src/components/modals/EditModulesModal/__tests__/EditMultipleModulesModal.test.tsx
Show resolved
Hide resolved
koji
reviewed
Apr 18, 2024
koji
approved these changes
Apr 18, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-16
Overview
the edit modules modal for MoaM now works for multiples, and the module row now has knowledge of all of the occupied slots
Test Plan
Make sure the MoaM ff is turned on and create a flex protocol. Add 1 temperature module in the create file wizard. Then edit the temperature modules and make sure it works as expected.
Changelog
EditModulesandEditModulesCardto accommodate the changegetModulesForEditModulesCardselector to accommodate moamReview requests
see test plan
Risk assessment
low