feat(opentrons-ai-client): add ChatDisplay component #14927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
reviewed
Apr 17, 2024
| render(props) | ||
| screen.getByText('OpentronsAI') | ||
| screen.getByText('mock text from the backend') | ||
| // Note (kk:04/16/2024) activate the following when jsdom's issue is solved |
There was a problem hiding this comment.
not sure if marking these comments as TODOs would be better?
jerader
reviewed
Apr 17, 2024
| gridGap={SPACING.spacing12} | ||
| paddingLeft={isUserInput ? SPACING.spacing40 : undefined} | ||
| paddingRight={isUserInput ? undefined : SPACING.spacing40} | ||
| // max-width="58.125rem" |
There was a problem hiding this comment.
will you add this back later?
There was a problem hiding this comment.
Still waiting for the answer from Sue
jerader
reviewed
Apr 17, 2024
|
|
||
| interface ChatDisplayProps { | ||
| text: string | ||
| isUserInput: boolean |
There was a problem hiding this comment.
this boolean prop seems okay for now. Is there ever a chance we will allow multi users in the chat at once? If so, maybe changing this to a prop called input and then InputType: 'backend' | 'user' could be better. Feel free to change the prop/type name!
There was a problem hiding this comment.
I don't think we will allow multi users to use the chat at once.
Actually, I still thinking of the implementation of user input part.
jerader
approved these changes
Apr 17, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* feat(opentrons-ai-client): add ChatDisplay component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add ChatDisplay component, its test, and its stories.
The display in Storybook isn't the same as the design since the component doesn't have markdown parse function yet.
The function will be implemented in a following PR.
close AUTH-209 partially
Test Plan
Changelog
Review requests
If you have any better idea for the component name, please let me know. (I don't like the current component name...)
Risk assessment
low